Refactoring

[artemgavrilov]

Description

Some refactoring:

1. Remove redundant argument from pgsm_create_hash_entry function
2. Move declarations that used in one place to that place (in the same file)
3. Little cleanup of main header file

Links

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.46%. Comparing base (a396cda) to head (11c8f12).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
- Coverage   86.47%   86.46%   -0.02%     
==========================================
  Files           3        3              
  Lines        1346     1345       -1     
  Branches      217      217              
==========================================
- Hits         1164     1163       -1     
  Misses         86       86              
  Partials       96       96              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[AndersAstrand]

sence->sense in the first commit message.

I think the second commit is an improvement, but I think we should introduce guc.h and hash_query.h to make things even better than having those "sections" in the one h-file.

If you don't feel like doing that we should commit this as is though.

[artemgavrilov]

sence->sense in the first commit message.

I think the second commit is an improvement, but I think we should introduce guc.h and hash_query.h to make things even better than having those "sections" in the one h-file.

If you don't feel like doing that we should commit this as is though.

Adding separate header files it's what I planned to suggest next 😄

Also what do you think about moving C sources to /src directory?

[jeltz]

Pretty sure there is more stuff in the pg_stat_monitor.h which could be moved into pg_stat_monitor.c but this is an iprovement on its own.