PG-2588 KMIP plan B redux - #642
Draft
jeltz wants to merge 4 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (76.49%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #642 +/- ##
==========================================
- Coverage 56.75% 56.74% -0.01%
==========================================
Files 71 72 +1
Lines 11236 11297 +61
Branches 2778 2781 +3
==========================================
+ Hits 6377 6411 +34
- Misses 3492 3525 +33
+ Partials 1367 1361 -6
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case we have to go with the plan B option this is just a quick branch where the upgrade of libmkip to the C++ version has been reverted.