Fix of pcp-atop conflict with atop on Fedora - #2685
Conversation
Make pcp-atop as optional dependency on RPM based distributions to allow users with installed atop to update PCP while keeping the already installed atop.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe RPM specifications now recommend ChangesRPM package relationship update
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@build/rpm/redhat.spec`:
- Line 3550: Update the changelog entry dated Aug 07 2026 to use the correct
weekday `Fri` instead of `Wed`, leaving the version, author, and other entry
details unchanged.
- Around line 2-3: Restore the RPM EVR in the spec metadata by keeping Version
at 7.2.1 and incrementing Release from the previously published value, unless
publication of 7.2.1-1 is verified not to have occurred. Do not use Version
7.2.0 with Release 2, since it lowers the package EVR.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: f116578a-c8bb-4bb4-a7c3-a1f5505ff166
📒 Files selected for processing (2)
build/rpm/pcp.spec.inbuild/rpm/redhat.spec
Make pcp-atop as optional dependency on RPM based distributions to allow users with installed atop to update PCP while keeping the already installed atop.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2510602