Skip to content

deb build: add postinst for libpcp-import2 /run/pmimport creation - #2688

Merged
natoscott merged 1 commit into
performancecopilot:mainfrom
natoscott:pmimport-postinst
Aug 10, 2026
Merged

deb build: add postinst for libpcp-import2 /run/pmimport creation#2688
natoscott merged 1 commit into
performancecopilot:mainfrom
natoscott:pmimport-postinst

Conversation

@natoscott

Copy link
Copy Markdown
Member

Fixes QA test 2007.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Added post-installation setup for required temporary files when systemd-tmpfiles is available.
    • Installation now reports a warning if temporary-file setup fails while allowing the installation to complete successfully.

Walkthrough

The Debian package now installs a post-installation script. The script runs systemd-tmpfiles --create for libpcp_import.conf when available, warns on failure, and exits successfully.

Changes

Debian post-install integration

Layer / File(s) Summary
Package post-installation wiring
debian/GNUmakefile, debian/libpcp-import2.postinst
The package file list includes the post-installation script. The script conditionally runs systemd-tmpfiles --create for libpcp_import.conf, emits a warning on failure, and exits successfully.

Possibly related PRs

Suggested reviewers: kmcdonell

Poem

A rabbit packs the Debian crate,
With tmpfiles ready at install state.
If systemd is near, the script will run,
A warning hops out if work is undone.
Then success brings the package home.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Debian post-installation change and its purpose of creating /run/pmimport.
Description check ✅ Passed The description states that the change fixes QA test 2007, which matches the pull request objective.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@debian/libpcp-import2.postinst`:
- Around line 9-14: Update the systemd-tmpfiles failure branch in the
post-install script to exit with status 1 after reporting the failure, instead
of continuing to the unconditional success exit. Preserve the existing warning
and successful path behavior.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 4083c7c9-c4bb-48b7-9dbd-0883ab7fc633

📥 Commits

Reviewing files that changed from the base of the PR and between 16dde5d and 86c77d0.

📒 Files selected for processing (2)
  • debian/GNUmakefile
  • debian/libpcp-import2.postinst

Comment thread debian/libpcp-import2.postinst
@natoscott
natoscott merged commit 4290094 into performancecopilot:main Aug 10, 2026
17 checks passed
@natoscott
natoscott deleted the pmimport-postinst branch August 10, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant