Repository navigation
Fix canvas zoom and component areas blocking the top bar - #114
Merged
Merged
Conversation
…p bar blocked it.
Spooky-Firefox
approved these changes
Sep 23, 2026
Spooky-Firefox
left a comment
Spooky-Firefox
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me
Spooky-Firefox
added a commit
that referenced
this pull request
Sep 23, 2026
The zoom fix (#114) added canvas_rect to Gui and disabled egui's built in keyboard zoom in gui(), but extended_mips builds the Gui through Gui::new/run (used by the mips-lib cli), which missed both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix canvas zoom and component areas blocking the top bar