codeartifact: normalize Cargo metadata accepts - #4
Merged
Conversation
Cargo sparse clients request config.json with Accept: text/plain, which makes CodeArtifact return a representation that Cachew cannot safely rewrite as JSON. Normalize Cargo metadata origin requests to application/json, including cross-origin redirects, while preserving the caller Accept header for other package formats. Verification: go test ./... -race -timeout 180s
ravi-pplx
marked this pull request as ready for review
September 1, 2026 03:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Cargo sparse-index clients request
config.jsonwithAccept: text/plain. Forwarding that header to CodeArtifact produces a non-JSON representation, so Cachew rejects the response and returns502 CodeArtifact origin unavailable. This prevents native Cargo from using Cachew as an unauthenticated CodeArtifact proxy.What changed
Accept: application/jsonbefore rewriting the response.Acceptvariants for all other package formats.Impact
Cargo
config.jsonresponses remain rewritten to Cachew download/API URLs withauth-required: false; other CodeArtifact package formats are unchanged.