ci: pin and verify MCP publisher artifact - #142
Draft
ronheichman wants to merge 1 commit into
Draft
Conversation
Author
|
@rbuchmayer-pplx @kesku Please review this bounded Code Red #57 hardening change. The forked PR test run is currently awaiting maintainer authorization; local build and all 90 repository tests pass, and the pinned publisher archive accepts the verified digest and deterministically rejects a mismatch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The MCP registry publish workflow downloads and executes the moving upstream
latestpublisher artifact in the same job that receivesMCP_REGISTRY_PRIVATE_KEY. Production environment approval limits when the job runs, but it does not verify which publisher binary receives that key. This creates a concrete registry-publication and credential-exposure path if the upstream publisher release channel is compromised.What changed
v1.8.1and its Linux amd64 asset.This is intentionally scoped to MCP registry publication. The separate npm OIDC/provenance workflow and other CLI release chains are unchanged.
Verification evidence
The pinned digest
a06c9096dcb9727c13555b6be26c7effa707b01f06a4c561ba7a3635443cf2ccagrees across the upstream checksum file, GitHub's release-asset digest, and an independently downloaded v1.8.1 archive. The verification command accepts that archive and rejects a mismatched digest before extraction.Review
MCP release owners: @rbuchmayer-pplx and @kesku.