Skip to content

perf: Box::pin removed for future returned by self.client_server_exchange(context) #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgrif merged 3 commits into from
Aug 21, 2026
+6 −10
Merged

perf: Box::pin removed for future returned by self.client_server_exchange(context) #1396

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69f9a0e
perf: stack-pin client_server_exchange instead of Box::pin
ygxio Aug 20, 2026
fb50f5f
perf: drop pin, pass exchange future to safe_timeout directly
ygxio Aug 21, 2026
0534116
perf: box cold multi-step branches to shrink the query future
ygxio Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions pgdog/src/frontend/client/query_engine/query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,10 @@ impl QueryEngine {
}
}

match safe_timeout(
context.timeouts.query_timeout(&State::Active),
Box::pin(self.client_server_exchange(context)),
)
.await
{
let query_timeout = context.timeouts.query_timeout(&State::Active);
let result = safe_timeout(query_timeout, self.client_server_exchange(context)).await;

match result {
Ok(response) => response?,
Err(err) => {
// Close the conn, it could be stuck executing a query
Expand All @@ -82,8 +80,7 @@ impl QueryEngine {
) -> Result<(), Error> {
match context.rewrite_result.take() {
Some(RewriteResult::InsertSplit(requests)) => {
multi_step::InsertMulti::from_engine(self, requests)
.execute(context)
Box::pin(multi_step::InsertMulti::from_engine(self, requests).execute(context))
.await?;
}

Expand All @@ -102,8 +99,7 @@ impl QueryEngine {
}

Some(RewriteResult::ShardingKeyUpdate(sharding_key_update)) => {
multi_step::UpdateMulti::new(self, &sharding_key_update)
.execute(context)
Box::pin(multi_step::UpdateMulti::new(self, &sharding_key_update).execute(context))
.await?;
}
}
Expand Down
Loading