Skip to content

refactor: deprecation warning for explicit set to 'pg_query_protobuf'; remove QueryParserEngine references in pgdog - #1420

Merged
jkaczman merged 3 commits into
mainfrom
jk-remove-query-parser-engine-refs
Aug 24, 2026
Merged

refactor: deprecation warning for explicit set to 'pg_query_protobuf'; remove QueryParserEngine references in pgdog#1420
jkaczman merged 3 commits into
mainfrom
jk-remove-query-parser-engine-refs

Conversation

@jkaczman

Copy link
Copy Markdown
Contributor

Removes internal QueryParserEngine fields/references that were no longer being used. Emits a deprecation warning if the user has query_parser_engine = "pg_query_protobuf" explicitly set in their pgdog.toml file.

…o 'pg_query_protobuf'; remove references in pgdog
@jkaczman
jkaczman requested a review from sgrif August 24, 2026 21:06

@levkk levkk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pgdog-config/src/core.rs 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@jkaczman
jkaczman merged commit e6db666 into main Aug 24, 2026
29 of 31 checks passed
@jkaczman
jkaczman deleted the jk-remove-query-parser-engine-refs branch August 24, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants