Fix File > Open Folder (⌘O) doing nothing - #10
Merged
Merged
Conversation
The menu item posted an .openFolder notification that nothing observed, so it did nothing. It now calls an action that ContentView publishes as a focused scene value, the same way the zoom commands work, so it acts on the frontmost window and is disabled when there isn't one. The folder panel moves into FolderPicker so the menu item and the welcome screen's Choose a Custom Folder button behave the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
File → Open Folder… (⌘O) posted an
.openFoldernotification that nothing listened for, so the menu item did nothing.ContentViewnow publishes anopenFolderActionfocused scene value, the same way the zoom commands already work. A newOpenFolderCommandsreads it, so ⌘O acts on the frontmost window and is disabled when there isn't one. This also avoids a notification firing in every open window.NSOpenPanelsetup moves intoFolderPicker, so ⌘O and the welcome screen's Choose a Custom Folder... button behave the same.startScanalready cancels any scan in progress, so ⌘O works from the welcome screen, during a scan, and from results.Testing
swift buildpasses under Swift 6 strict concurrency.WelcomeView.🤖 Generated with Claude Code