Remove unused TreemapHitTester and dedupe hit testing - #16
Merged
Merged
Conversation
TreemapHitTester was never instantiated: hit testing moved into TreemapView when zoom and pan were added, because it needs the screen to content transform first. TreemapView then had two copies of the same reverse-order lookup. hitTestID now calls hitTestItem, which uses items.last(where:) and returns the same item as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TreemapHitTesterfromTreemapLayout.swift. It was never instantiated. Hit testing moved intoTreemapViewwhen zoom and pan were added (061ca7a), since it needs the screen-to-content transform first, and this struct was left behind.TreemapView's hit testing.hitTestID(at:)andhitTestItem(at:)were two copies of the same reverse loop.hitTestIDnow returnshitTestItem(at:)?.id, andhitTestItemusesitems.last(where:). It finds the same item as before (the deepest one, drawn on top), so hover, selection and drill-down don't change.Testing
swift buildpasses, and nothing references the removed struct.scripts/smoke-test.sh.🤖 Generated with Claude Code