JAtom int/long direct call to representation - #188
Merged
Conversation
Basically the IntegerRepresentation is only the params. The EIntegerBase is the one doing the formatting. also renamed "represent()" to "format()", more explicit also renamed field representation to m_aRepresentation, using getter representation() instead.
phax
reviewed
Aug 30, 2026
| // actual formatting is delegated to the base | ||
| // | ||
|
|
||
| public String format (int i) |
Owner
There was a problem hiding this comment.
Why remove these sanity methods? Isn't that something you usually like?
Collaborator
Author
There was a problem hiding this comment.
I just moved the call ? instead of applying to the Representation, which calls the base with itself as params, I directly call the base with the Representation as param.
This was something you mentionned in the previous PR, but was left off when merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically the IntegerRepresentation is only the params. The EIntegerBase is the one doing the formatting.
also renamed "represent()" to "format()", more explicit
also renamed field representation to m_aRepresentation, using getter representation() instead.