Conversation
release:dev fails on windows only, at createDistCacheManifest: the dev dist cache came to 78203 KB against a hardcoded 78000 KB ceiling that was shared by every release chain. Dev builds ship unminified sources and keep the phoenix-pro sources in dist, so they are legitimately larger than prod. Split the ceiling into MAX_CACHE_SIZE_KB_PROD (78000, unchanged) and MAX_CACHE_SIZE_KB_DEV (100000), matching the DEV_MAX_TOTAL_SIZE_MB / PROD_MAX_TOTAL_SIZE_MB split that already exists in validate-build.js. releaseDev gets its own createDistCacheManifestDev task; staging and prod are unchanged. src/cacheManifest.json only matters when the src tree itself is served (npm run serve). Releases ship dist/, whose manifest is regenerated by createDistCacheManifest and overwrites the copy makeDistNonJS carried over, so the src manifest takes the dev limit in both chains. The shipped artefact is still guarded by createDistCacheManifest and validateDistSizeRestrictions at their existing prod limits. Also report the actual limit and measured size in the error message instead of always naming 78MB.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.