[module] [lua] Pet EXP Module - #180
Open
KiplingFFXI wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
This PR adds a custom module that cuts the EXP awarded for killing another monster's pet when the killing party has more than 3 members. Parties of 3 or fewer are untouched. At 4 members pets give 30% of their normal value, (70% penalty) at 5 members 20% (80% penalty), and at 6 or more 10% (90% penalty).
"Pet" means a mob with an actual master link (everything wired up through xi.pet.setMobPet), so beastmen jug pets, wyverns, avatars, and elementals are included. Adds spawned as loose helpers through callPets have no master and are not affected.
Player-owned pets are excluded. Charmed mobs and jug pets have a player master, and the module checks that the master is a mob before touching anything.
Also, if you engage a pet with 4-6 in your party and then people drop, the penalty is still not avoided. It is calculated base don the party size you had on engage.
Steps to test these changes
Load the module. Kills pets as a party of 3 and see its normal. Kill as a party of 4-6 and see your EXP is severely reduced.