Skip to content

[Phoenix] Anniversary Ring for New Characters - #185

Open
KiplingFFXI wants to merge 1 commit into
phoenixffxi:betafrom
KiplingFFXI:Anniversary-Ring-New-Characters
Open

[Phoenix] Anniversary Ring for New Characters#185
KiplingFFXI wants to merge 1 commit into
phoenixffxi:betafrom
KiplingFFXI:Anniversary-Ring-New-Characters

Conversation

@KiplingFFXI

Copy link
Copy Markdown

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR adds an anniversary ring to every new character upon the end of the starter cutscene. It also blocks character who obtained one previously from getting another one when they swap nations and see the first time CS. The ring is only granted to legitimately new characters, and only one time.

Steps to test these changes

Load the module and see all of the above.

@CriticalXI CriticalXI left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a check for if the player has received the anni band already, because you get the new player cutscene again if you change nations.

@KiplingFFXI

Copy link
Copy Markdown
Author

Needs a check for if the player has received the anni band already, because you get the new player cutscene again if you change nations.

Should already be covered. firstViewing is read before the base handler sets the nation bit, so changing nations replays the cutscene without granting the ring. I tested it as well to make sure it doesnt hand it out twice if you swap nations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants