[Phoenix] Anniversary Ring for New Characters - #185
Open
KiplingFFXI wants to merge 1 commit into
Open
Conversation
CriticalXI
reviewed
Aug 23, 2026
CriticalXI
left a comment
Member
There was a problem hiding this comment.
Needs a check for if the player has received the anni band already, because you get the new player cutscene again if you change nations.
Author
Should already be covered. firstViewing is read before the base handler sets the nation bit, so changing nations replays the cutscene without granting the ring. I tested it as well to make sure it doesnt hand it out twice if you swap nations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
This PR adds an anniversary ring to every new character upon the end of the starter cutscene. It also blocks character who obtained one previously from getting another one when they swap nations and see the first time CS. The ring is only granted to legitimately new characters, and only one time.
Steps to test these changes
Load the module and see all of the above.