qa/analysis sql - #158
Merged
Merged
Conversation
Member
|
Needs updated to align with qa-tools but other than that. Its good. |
tyrsson
requested changes
Aug 12, 2026
tyrsson
left a comment
tyrsson
left a comment
Member
There was a problem hiding this comment.
Just need to align it with qa-tools
simon-mundy
force-pushed
the
qa/analysis-sql
branch
from
August 23, 2026 12:16
80fb979 to
f50e9fb
Compare
The adapter query split merged from 0.6.x arrived unformatted and shifted several baselined findings, so both baselines no longer matched.
phpdb-qa-tools renamed qa.yml to continuous-integration.yml on 0.1.x, so the existing reference no longer resolved and CI could not start.
simon-mundy
force-pushed
the
qa/analysis-sql
branch
from
August 23, 2026 12:20
f50e9fb to
3ab788f
Compare
tyrsson
previously requested changes
Aug 23, 2026
tyrsson
left a comment
tyrsson
left a comment
Member
There was a problem hiding this comment.
ci.yml -> continuous-integration.yml
mago is failing due to [Override] usage
Otherwise looks good as far as I can see.
Resolves 58 missing-override-attribute findings in the code rather than suppressing them, dropping the analyzer baseline from 1173 to 1115 entries. Baselines regenerated under PHP 8.4; verified against 8.2 through 8.5.
tyrsson
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬