Add RowPrototypeResultSet; migrate RowGateway to populate() - #164
Merged
Conversation
- Trim ResultSetInterface down to Iterator/Countable/initialize/getFieldCount/toArray - Add standalone ArrayObjectResultSetInterface and HydratingResultSetInterface capability interfaces (combined via implements + intersection types, not inheritance), so setRowPrototype()/getRowPrototype() no longer force a wide ArrayObject|RowPrototypeInterface union onto every implementation - ResultSet narrows to ArrayObject-only; HydratingResultSet keeps its intentionally wide object typing, now isolated to its own interface - Move toArray() out of AbstractResultSet; each concrete class implements only the row-casting logic it actually needs
Dedicated ResultSet implementation for plain-array rows, decoupled from ArrayObjectResultSetInterface's row-prototype capability entirely.
- New RowPrototypeResultSet/RowPrototypeResultSetInterface: dedicated, ArrayObject-free ResultSet implementation for RowPrototypeInterface prototypes (e.g. RowGateway) - Rename RowPrototypeInterface::exchangeArray() to populate(), returning RowPrototypeInterface. Avoids the ArrayObject-associated vocabulary bleeding across the ArrayObjectResultSet/RowPrototypeResultSet split; whether population is mutating or returns a new instance is left as an implementation detail of the prototype, not the ResultSet - AbstractRowGateway::populate() return type widened to static to satisfy RowGatewayInterface's new populate() contract (behavior unchanged, it already returned $this) - RowGatewayFeature migrated from ResultSet (now ArrayObject-only) to RowPrototypeResultSet, calling setRowPrototype() directly
tyrsson
force-pushed
the
resultset-row-prototype
branch
from
August 24, 2026 00:44
0f15f70 to
075961e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
tyrsson
marked this pull request as ready for review
August 24, 2026 00:58
simon-mundy
approved these changes
Aug 24, 2026
tyrsson
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArrayObject-free ResultSet implementation for RowPrototypeInterface
prototypes (e.g. RowGateway)
RowPrototypeInterface. Avoids the ArrayObject-associated vocabulary
bleeding across the ArrayObjectResultSet/RowPrototypeResultSet split;
whether population is mutating or returns a new instance is left as an
implementation detail of the prototype, not the ResultSet
RowGatewayInterface's new populate() contract (behavior unchanged, it
already returned $this)
RowPrototypeResultSet, calling setRowPrototype() directly
Stack created with GitHub Stacks CLI • Give Feedback 💬