fix(CLI): publish binaries even when sign and notarize fails - #1219
Open
jablan wants to merge 1 commit into
Open
fix(CLI): publish binaries even when sign and notarize fails#1219jablan wants to merge 1 commit into
jablan wants to merge 1 commit into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
releasejob so all binaries (linux, windows, macos) are always published, regardless of signing outcomecontinue-on-error: truetosign_and_notarize— it still runs and overwrites the macOS assets with signed versions on success, but its failure no longer blocks the releasebrewtoneeds: [release, sign_and_notarize]withif: always() && needs.release.result == 'success'so Homebrew bump waits for signing when possible but isn't blocked by signing failuresFixes: https://github.com/phrase/phrase-cli/actions/runs/28353873876/job/83992891160
Test plan
🤖 Generated with Claude Code