refactor: remove registry and guard surfaces - #107
Merged
Conversation
odyslam
requested review from
fredo,
lean-apple,
makemake-kbo and
mateo-mro
as code owners
August 6, 2026 23:28
makemake-kbo
previously approved these changes
Aug 7, 2026
mateo-mro
reviewed
Aug 7, 2026
|
|
||
| ### Added | ||
|
|
||
| - **Credible Block Guard**: `CredibleBlockGuard` reusable mixin (`src/protection/credible_block/`) exposing an `onlyCredibleBlock` modifier that gates functions on block credibility via the on-chain Credible Registry, failing open when the credible builder set goes offline so protected contracts are never bricked. Ships with an ABI-compatible `ICredibleRegistry` interface (matching `phylaxsystems/credible-registry`) and a full test suite. |
There was a problem hiding this comment.
CredibleBlockGuard is already part of the published 0.7.0 tag, so this removes a released import path while deleting its only changelog entry. Could we keep an Unreleased removal note that points consumers to the companion registry package and treat the next release as source breaking?
Signed-off-by: odysseas.eth <odyslam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SafeConfigLockAssertionandSafeTxShapeAssertion.Test plan
forge fmt --checkforge buildFOUNDRY_PROFILE=ci pcl test --match-path 'test/protection/safe/SafeConfigLockAssertion.t.sol'(11 passed)FOUNDRY_PROFILE=ci pcl test --match-path 'test/protection/safe/SafeTxShapeAssertion.t.sol'(57 passed)git diff --checkCompanion PR
credible-registry#5 makes
credible-registryauthoritative for the moved registry and guard surfaces.