improve rp6502_xram and add CI - #19
Merged
Merged
Conversation
Every commit to main builds the examples with cc65 from the official repository and publishes rp6502-<commit>-examples.zip, holding one ROM per example and a README saying what they are. The generated programs rp6502_xram() leaves in the build tree are named for the function now. One of them was a plain stub.rp6502, which reads like a ROM anyone would ship. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
They sit in CMakeFiles/<header>.xram, which already says whose they are, so xram_stub.c reads better than rp6502_xram_stub.c. The extern in the check program and the custom target keep the longer prefix, because both of those names are shared with code and targets we do not own. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The archive was built from outside the staging directory, so everything landed one folder down. GitHub zips an artifact on the way out as well, so uploading the zip gave a zip holding a zip; the artifact is now the directory. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The declaration shares a translation unit with the layout header, and a leading underscore at file scope is the one namespace a name there cannot take from the header. rp6502_ stays on the CMake target, where the names are ours and global. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
GitHub appends .zip when an artifact is downloaded, so the name it lists can never carry the extension without doubling it. The release asset is the one that ships and it is named for what it is, so the artifact was only a second thing with almost the same name. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
A pull request publishes nothing, so the artifact is the only way to open what it built. It is named for the run rather than the commit, because a pull request's HEAD is a merge commit nobody can look up, and because two downloads called rp6502-<something>-examples.zip should not be the same name for a release and a trial build. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
GitHub serves an artifact download under the artifact's own name, adding .zip only when it is not already there, so the name may carry it and the file still arrives as one archive of loose ROMs. This is what rp6502 does with its own build artifacts. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.