Skip to content

[DataObject] Add searchPath option to Image, Hotspotimage & ImageGallery - #19364

Draft
cancan101 wants to merge 1 commit into
pimcore:2026.xfrom
cancan101:claude/pimcore-17157-review-izuslv
Draft

[DataObject] Add searchPath option to Image, Hotspotimage & ImageGallery#19364
cancan101 wants to merge 1 commit into
pimcore:2026.xfrom
cancan101:claude/pimcore-17157-review-izuslv

Conversation

@cancan101

Copy link
Copy Markdown
Contributor

Adds a new "searchPath" class-definition setting next to "uploadPath" for the image-flavored data types. While uploadPath only targets inline uploads, searchPath lets the asset search dialog of the field open pre-scoped to a configured asset folder (as a visible, user-clearable filter — a soft default, not a restriction).

The property is serialized to the UI automatically via the public-props JSON serialization, so the admin UIs (Studio / classic) can consume it from the field configuration.

Changes in this pull request

Resolves #17157

Additional info

Additional info: UI support implemented in pimcore/studio-ui-bundle#3993, the property is inert without it.

Adds a new "searchPath" class-definition setting next to "uploadPath"
for the image-flavored data types. While uploadPath only targets inline
uploads, searchPath lets the asset search dialog of the field open
pre-scoped to a configured asset folder (as a visible, user-clearable
filter — a soft default, not a restriction).

The property is serialized to the UI automatically via the public-props
JSON serialization, so the admin UIs (Studio / classic) can consume it
from the field configuration.

Refs pimcore#17157

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rf6z83yKPGdQKoVS5B2UeT
Copilot AI balanced review requested due to automatic review settings August 14, 2026 21:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

Review Checklist

  • Target branch (12.3 for bug fixes, others 2026.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@pimcore-deployments
pimcore-deployments marked this pull request as draft August 14, 2026 21:12
@pimcore-deployments

Copy link
Copy Markdown
Collaborator

🚫 Issue-link guardrail failed — this PR has been converted to draft.

Every PR must reference a tracking issue in pimcore/platform-version so the change stays traceable.

  • Resolves #17157 is not valid: issue not found.

Add the link with a keyword in the PR description (not in a comment): https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

When fixed, press Ready for review to re-run the checks.

@pimcore-deployments

Copy link
Copy Markdown
Collaborator

🚫 CI & merge-readiness guardrail failed — this PR has been converted to draft.

A PR can only be merged when it has no conflicts with the base branch and all CI checks pass.

  • CI check not successful: Milestone assigned (failure).

When fixed, press Ready for review to re-run the checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Option to Limit Search Path for Images

5 participants