Skip to content

Forward-merge 3.6 into 2026.2 (ancestry only — DO NOT SQUASH) - #154

Merged
berfinyuksel merged 3 commits into
2026.2from
merge/3.6-to-2026.2
Aug 14, 2026
Merged

Forward-merge 3.6 into 2026.2 (ancestry only — DO NOT SQUASH)#154
berfinyuksel merged 3 commits into
2026.2from
merge/3.6-to-2026.2

Conversation

@berfinyuksel

Copy link
Copy Markdown
Contributor

⚠️ Merge with "Create a merge commit" — do not squash

Squashing collapses this into a single-parent commit, which does not restore ancestry. 3.6 would still read diverged and would still block the next patch release. That is the entire point of this PR.

What this is

3.6 carried two commits (#150 and its auto-applied cs-fixer commit) that were never forward-merged. The pre-flight release check compares ancestry, not content, so 3.6 reads diverged and blocked v3.6.3 last week.

Net content change: none

The one conflict, .github/workflows/php-cs-fixer.yaml, is resolved in favour of 2026.2. This is deliberate: 3.6 also has a pull_request_target trigger and therefore needs repository: \${{ github.event.pull_request.head.repo.full_name || github.repository }}. 2026.2 is push-only and correctly uses github.repository with an if: github.repository_owner == 'pimcore' guard. Propagating 3.6's variant upward would put a fork-checkout expression into a push-only workflow.

Verified before pushing:

git diff --stat origin/2026.2 HEAD   ->  (empty)
git merge-base --is-ancestor origin/3.6 HEAD  ->  YES

Context

Follow-up to pimcore/service-operations#1071. The sweep fixed the workflow on 15 maintenance branches but left the ancestry unrepaired; 13 branches across 10 repos are in this state. This is the reference case — the rest follow the same pattern.

Next leg after this merges: 2026.2 -> 2026.x.

berfinyuksel and others added 3 commits July 31, 2026 12:50
Ancestry-only forward merge. The php-cs-fixer.yaml conflict is resolved in
favour of 2026.2: 3.6 carries a pull_request_target trigger that 2026.2 does
not, so 3.6's workflow variant must not propagate upward.

Net content change against 2026.2: none.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings August 14, 2026 09:12
@berfinyuksel berfinyuksel added this to the 2026.2.1 milestone Aug 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sonarqubecloud

Copy link
Copy Markdown

@berfinyuksel
berfinyuksel merged commit 153d406 into 2026.2 Aug 14, 2026
11 checks passed
@berfinyuksel
berfinyuksel deleted the merge/3.6-to-2026.2 branch August 14, 2026 09:18
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants