[DataObject] [Classification Store] Fix selection modal: grid does not use full modal width and columns are not resizable - #3971
Merged
ValeriaMaltseva merged 2 commits intoAug 20, 2026
Conversation
…izing The Collection/Gruppe/"Nach Schlüssel gruppieren" selection grids never passed `resizable`/`autoWidth` to Grid, unlike every other Studio grid, so the table rendered at the sum of TanStack's default 150px column widths instead of the modal's full width, and columns could not be dragged wider.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes classification-store selection grids so they fill the modal width and support column resizing.
Changes:
- Enables
autoWidthandresizableon shared selection grids. - Adds stable column definitions with explicit sizes and one flexible column per tab.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tabs/group/group-tab.tsx |
Adds sized, flexible group columns. |
tabs/group-by-key/group-by-key-tab.tsx |
Adds sized, flexible key columns. |
tabs/collection/collection-tab.tsx |
Adds sized, flexible collection columns. |
components/classification-store-data-tab/classification-store-data-tab.tsx |
Enables full-width, resizable grids. |
components/classification-store-data-tab/classification-store-callback-tab.tsx |
Enables full-width, resizable callback grids. |
|
albertmueller
marked this pull request as ready for review
August 7, 2026 08:06
ValeriaMaltseva
self-requested a review
August 7, 2026 08:08
kingjia90
approved these changes
Aug 20, 2026
kingjia90
left a comment
Contributor
There was a problem hiding this comment.
Verified against the Grid component API and all call sites:
autoWidth/resizableare realGridprops (grid.tsx:60,grid.tsx:250) and the per-columnmeta: { autoWidth: true }fill-pattern is the same one used by other Studio grids (e.g. saved-searches tab) — this brings the CS modal in line with the rest of Studio.- The one-autoWidth-column-per-grid validation in
grid.tsx(validate if only one column has autoWidth) is respected: each tab defines exactly one flexible column. - The two shared renderers (
classification-store-data-tab.tsx,classification-store-callback-tab.tsx) are only consumed by the three updated tabs (collection / group / group-by-key), so no other grid picks up the new behaviour unintentionally. useMemoon the column defs with[t]is correct and now actually load-bearing, since the grid's autoWidth validation memoizes on column identity.- Copilot: no findings. CI green (build, lint, types, Codeception, PHPStan, Sonar).
I added Fixes pimcore/platform-version#304 to the description so the issue-link guardrail passes and the issue auto-closes on merge.
ValeriaMaltseva
approved these changes
Aug 20, 2026
ValeriaMaltseva
left a comment
Contributor
There was a problem hiding this comment.
@albertmueller
Hi! I really appreciate your help. Thanks! :)
I'll merge the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
In the ClassificationStore selection modal (opened from the DataObject edit view when adding
a Collection/Group/Key to a
classificationstorefield), the selection grid in all three tabs("Collection", "Gruppe"/"Group", "Nach Schlüssel gruppieren"/"Group by key") renders at a fixed
width far narrower than the modal itself, and its columns cannot be resized by dragging the
column border — unlike virtually every other grid in Studio (e.g. Predefined Properties,
Translations, Document Types).
Steps to reproduce
classificationstorefield in Studio.with a lot of empty space to the right.
Expected behavior
autoWidthelsewhere).Actual behavior
of the modal empty.
Root cause
ClassificationStoreDataTabandClassificationStoreCallbackTab(
src/core/modules/element/dynamic-types/definitions/objects/data-related/components/classification-store/components/classification-store-modal/components/classification-store-data-tab/)render their
<Grid>without theresizableandautoWidthprops. Both props are required forGridto enable column resizing (Resizer) and full-width layout — seesrc/core/components/grid/grid.tsx. Every other grid in the codebase that wants full-width /resizable behavior sets both props explicitly (e.g.
src/core/modules/predefined-properties/table/table.tsx).Environment
Fixes pimcore/platform-version#304
A fix is ready: adds
resizable/autoWidthto the two<Grid>usages and sets explicit columnsizes with one
autoWidthcolumn per tab (Collection/Group/GroupByKey), so the last column fillsthe remaining space. PR will follow from branch
fix/classification-store-modal-grid-width.Fixed state:

Fixes pimcore/platform-version#304