Skip to content

Remove duplicate entry validation in website settings creation - #3992

Draft
jheimbach wants to merge 1 commit into
pimcore:2026.xfrom
jheimbach:remove-duplication-check-website-settings
Draft

Remove duplicate entry validation in website settings creation#3992
jheimbach wants to merge 1 commit into
pimcore:2026.xfrom
jheimbach:remove-duplication-check-website-settings

Conversation

@jheimbach

Copy link
Copy Markdown

Changes in this pull request

Resolves pimcore/platform-version#317

Additional info

Copilot AI balanced review requested due to automatic review settings August 14, 2026 09:35
@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@pimcore-deployments
pimcore-deployments marked this pull request as draft August 14, 2026 09:35
@pimcore-deployments

Copy link
Copy Markdown
Collaborator

🚫 CI & merge-readiness guardrail failed — this PR has been converted to draft.

A PR can only be merged when it has no conflicts with the base branch and all CI checks pass.

  • CI check not successful: cla-workflow / CLAAssistant (failure).

When fixed, press Ready for review to re-run the checks.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes client-side duplicate-name validation when creating website settings.

Changes:

  • Removes the duplicate-entry modal and validation.
  • Deletes obsolete translations across all supported locales.
  • Retains mandatory-field validation.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
website-settings-container.tsx Removes duplicate-name validation and modal.
studio.en.yaml Removes obsolete English messages.
studio.de.yaml Removes obsolete German messages.
studio.es.yaml Removes obsolete Spanish messages.
studio.fr.yaml Removes obsolete French messages.
studio.it.yaml Removes obsolete Italian messages.
studio.no.yaml Removes obsolete Norwegian messages.
studio.sv.yaml Removes obsolete Swedish messages.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jheimbach

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@sonarqubecloud

Copy link
Copy Markdown

@ValeriaMaltseva
ValeriaMaltseva self-requested a review August 17, 2026 09:26
@ValeriaMaltseva ValeriaMaltseva self-assigned this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Website Settings with same name but different site/language is not allowed

4 participants