Skip to content

feat(web): add configurable settle shortcut - #5940

Closed
jackmhny wants to merge 1 commit into
pingdotgg:mainfrom
jackmhny:agent/add-configurable-settle-keybinding
Closed

feat(web): add configurable settle shortcut#5940
jackmhny wants to merge 1 commit into
pingdotgg:mainfrom
jackmhny:agent/add-configurable-settle-keybinding

Conversation

@jackmhny

@jackmhny jackmhny commented Aug 10, 2026

Copy link
Copy Markdown

Problem

Settling the open thread is only available through pointer-driven thread actions. The keybinding schema does not recognize a settle command, so users cannot add their own shortcut in Settings or keybindings.json.

Change

  • register thread.settle as a supported keybinding command
  • include every supported static command in the Settings command picker, even when it has no default binding
  • dispatch the shortcut through the existing settlement checks and failure handling
  • document the command and cover schema, picker, and shortcut resolution behavior with focused tests

This intentionally adds no default chord, so existing keymaps do not change and users can choose a conflict-free shortcut.

Related: #4277 and #4876. Both currently conflict with main; this draft is a smaller, freshly rebased configurable-only alternative.

Impact

Users can select Thread: Settle from Settings → Keybindings or add thread.settle to keybindings.json. The existing lifecycle rules still prevent settling threads that need attention, and failures use the existing toast path.

Validation

  • vp test run packages/contracts/src/keybindings.test.ts apps/web/src/keybindings.test.ts apps/web/src/components/settings/KeybindingsSettings.logic.test.ts — 66 tests passed
  • scoped contracts and web typechecks passed
  • targeted lint and format checks passed
  • production web build passed

Created with Codex in T3 Code.

Note

Add configurable thread.settle keyboard shortcut to global chat shortcuts

  • Adds 'thread.settle' to THREAD_KEYBINDING_COMMANDS and exports STATIC_KEYBINDING_COMMANDS from keybindings.ts so consumers can reference static commands.
  • Handles the thread.settle command in _chat.tsx, calling settleThread on the active thread and showing an error toast on failure (unless interrupted).
  • Updates buildKeybindingCommandOptions in KeybindingsSettings.logic.ts to seed the command list with STATIC_KEYBINDING_COMMANDS, so thread.settle appears in the keybindings settings UI with no default shortcut assigned.

Macroscope summarized 8cb3344.


Note

Low Risk
Reuses existing thread settlement APIs and UI toasts; no default binding means no behavior change until users configure a shortcut.

Overview
Adds thread.settle as a first-class keybinding command so users can settle the open thread from the keyboard without changing anyone’s default keymap.

The contracts layer registers the command and exports STATIC_KEYBINDING_COMMANDS, and the Settings command picker is seeded from that list so commands like settle show up even when they have no built-in chord. On the chat route, a resolved thread.settle shortcut calls the same settleThread path as the thread menu, with existing failure toasts; repeats and missing route thread are ignored.

User docs note that settle has no default shortcut—users add one in Settings or keybindings.json. Tests cover schema acceptance, picker options, and shortcut resolution with when context.

Reviewed by Cursor Bugbot for commit 8cb3344. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 37200055-6882-4533-ad0d-fd8a7be3de58

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 10, 2026
@jackmhny
jackmhny marked this pull request as ready for review August 10, 2026 02:51
@macroscopeapp

macroscopeapp Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 8cb3344

This PR exposes an existing thread settle action through a configurable keyboard shortcut. The changes are additive, well-tested, and follow existing patterns - the underlying functionality already exists and this simply adds a new keybinding command to trigger it.

You can customize Macroscope's approvability policy. Learn more.

@t3dotgg

t3dotgg commented Aug 25, 2026

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

Closing in favor of merged #8089. It adds the configurable thread.settle shortcut and uses the same shortcut to settle or restore the active thread. Your work is credited in #8089.

@t3dotgg t3dotgg closed this Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants