Skip to content

fix(web): replace the update tooltip with a changelog popover - #7880

Open
RakshithBhat03 wants to merge 5 commits into
pingdotgg:mainfrom
RakshithBhat03:fix/update-changelog-popover
Open

fix(web): replace the update tooltip with a changelog popover#7880
RakshithBhat03 wants to merge 5 commits into
pingdotgg:mainfrom
RakshithBhat03:fix/update-changelog-popover

Conversation

@RakshithBhat03

@RakshithBhat03 RakshithBhat03 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Nightly update notes were rendered in a tooltip, so the panel disappeared when the pointer moved into it and long changelogs were difficult to read or scroll.

Nightly updates with release notes now use a hover popover that stays open while reading and scrolling. Compared with the superseded #7876 draft, the sidebar pill keeps its original direct action: clicking an available update immediately starts the download, while clicking a downloaded update invokes the existing restart/install flow. The popover contains only the update status and changelog, with no duplicate Download or Restart and install buttons.

Stable updates and states without release notes continue using the existing tooltip. The trigger remains a native button with its accessible label and visible focus treatment. The popover has a screen-reader title and does not move focus away from the trigger when it opens.

Tests: 42 focused tests, lint, format check, and git diff --check passed; local browser pass covered both update states, changelog scrolling, and direct sidebar download/restart-install actions. Web typecheck still reports two pre-existing conditionalUI errors in src/components/clerk/electronPasskeys.test.ts.

Screenshots

Update ready to download

Before After
Nightly update ready to download in the previous tooltip Nightly update ready to download in the hover popover with no action button

Update downloaded

Before After
Downloaded nightly update in the previous tooltip Downloaded nightly update in the hover popover with no action button

Built by GPT-5.6 Sol in T3 Code through the Codex harness.

Summary by CodeRabbit

  • New Features
    • Nightly updates with available release notes now open an interactive popover for easier reading.
    • Release notes are displayed in a scrollable panel without leaving the current view.
    • Updates without release notes continue to provide a helpful fallback tooltip.
    • Update controls now support consistent hover, focus, click, and disabled states for improved accessibility and interaction.

Note

Low Risk
UI-only sidebar interaction change with no auth, data, or update-backend logic. Focus/hover close handling is the main behavioral risk.

Overview
Nightly updates with release notes no longer live in a tooltip that closes when the pointer moves into it. They now open as a hover popover so the changelog can be read and scrolled.

The sidebar pill still runs download or restart/install on click. The popover is changelog-only (no duplicate action buttons), stays open while hovered or focused, and does not steal focus. Stable updates and empty notes keep the existing tooltip.

Reviewed by Cursor Bugbot for commit da6109b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Replace sidebar update tooltip with a hover-driven changelog popover

  • Nightly builds with available release notes now show a dedicated hover popover (SidebarUpdateReleaseNotesPopover) instead of embedding rich content inside the tooltip.
  • SidebarUpdateReleaseNotes is renamed from SidebarUpdateReleaseNotesTooltip and no longer applies its own max-width or scrolling — the popover handles sizing and viewport constraints.
  • SidebarUpdateControl gates the popover on showReleaseNotesPopover (nightly + non-empty release notes); all other builds fall back to a plain-text Tooltip.
  • Clicking the trigger starts the update and closes the popover without toggling it; onBlur only closes when neither hover nor focus remains inside the popover.
  • Behavioral Change: Tooltip no longer renders release-notes markup; any code expecting rich content inside the tooltip will see plain text only. Reviewers should check SidebarUpdateControl trigger handlers and SidebarUpdateReleaseNotes callers.

Macroscope summarized da6109b.

@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7801935e-b64f-4eb8-9188-4bcf28733aec

📥 Commits

Reviewing files that changed from the base of the PR and between 11f0513 and 301fb41.

📒 Files selected for processing (2)
  • apps/web/src/components/sidebar/SidebarUpdatePill.test.tsx
  • apps/web/src/components/sidebar/SidebarUpdatePill.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

SidebarUpdatePill now displays nightly release notes in a hoverable popover. Other update states retain tooltip behavior. Tests cover rendering, focus, blur, clicks, downloads, and fallback content.

Changes

Sidebar update release notes

Layer / File(s) Summary
Release notes presentation
apps/web/src/components/sidebar/SidebarUpdatePill.tsx
The component adds a standalone release-notes panel, popover state, popover imports, and scroll-limited viewport styling.
Conditional trigger flow
apps/web/src/components/sidebar/SidebarUpdatePill.tsx, apps/web/src/components/sidebar/SidebarUpdatePill.test.tsx
Nightly updates with release notes use the popover. Other states use the tooltip. Tests cover trigger actions, focus, blur, popover rendering, and fallback behavior.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 301fb

This PR makes nightly release notes easier to read and scroll while preserving existing download and restart/install actions. No actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: stienswout, t3dotgg

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes replacing the update tooltip with a changelog popover.
Description check ✅ Passed The description explains the change and rationale, documents UI changes with before/after screenshots, and includes testing and known typecheck issues.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Aug 22, 2026

@macroscopeapp macroscopeapp Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the new hover-only release-notes popover removes keyboard access to the update details that the tooltip previously provided on focus. Details inline.

Posted via Macroscope — UI Consistency

Comment thread apps/web/src/components/sidebar/SidebarUpdatePill.tsx
@RakshithBhat03 RakshithBhat03 changed the title fix(web): keep update changelogs open without changing pill actions fix(web): keep update notes readable while preserving pill actions Aug 22, 2026
@RakshithBhat03 RakshithBhat03 changed the title fix(web): keep update notes readable while preserving pill actions fix(web): replace the update tooltip with a changelog popover Aug 22, 2026
@RakshithBhat03

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@RakshithBhat03
RakshithBhat03 marked this pull request as ready for review August 22, 2026 09:09
Comment thread apps/web/src/components/sidebar/SidebarUpdatePill.tsx Outdated
@macroscopeapp

macroscopeapp Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Skipped

Macroscope did not run approvability analysis for this PR. Macroscope could not determine whether this PR modifies its approvability configuration, so the PR was not approved automatically. A PR that may change the rules that govern approval is never approved automatically.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1521d6d. Configure here.

Comment thread apps/web/src/components/sidebar/SidebarUpdatePill.tsx Outdated
@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 22, 2026

@macroscopeapp macroscopeapp Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the release-notes popover branch drops the update-state surface treatment that the tooltip branch still applies for the same update states.

Posted via Macroscope — UI Consistency

Comment thread apps/web/src/components/sidebar/SidebarUpdatePill.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant