fix(librarian): correct stale advanced-toggle CSS classes - #41
Open
unleashedgenius wants to merge 1 commit into
Open
fix(librarian): correct stale advanced-toggle CSS classes#41unleashedgenius wants to merge 1 commit into
unleashedgenius wants to merge 1 commit into
Conversation
The Librarian settings' "Show Advanced" toggle used dle-advanced-chevron and dle-advanced-content, which have no matching rules in style.css. Every other Advanced toggle in settings-popup.html (Vault Tags, Matching, Injection, AI Prompt & Context, AI Filtering, AI Search, Index) uses dle-advanced-icon / dle-advanced-section, which are styled at style.css:282 and style.css:849. Align the Librarian toggle with the established convention so it gets the same chevron and collapsible styling as the rest of the settings panel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Librarian settings' "Show Advanced" toggle in
settings-popup.htmluseddle-advanced-chevronanddle-advanced-contentclasses, which have no matching rules instyle.css. Every other "Show Advanced" toggle in the same file (Vault Tags, Matching, Injection, AI Prompt & Context, AI Filtering, AI Search, Index — 7 total) correctly usesdle-advanced-icon/dle-advanced-section, which are styled atstyle.css:282andstyle.css:849.As a result, only the Librarian Advanced toggle rendered without the chevron rotation/spacing styling that every other Advanced section gets.
Root cause
Likely a naming-convention drift — the Librarian section's markup used an earlier/local class-naming scheme (
-chevron/-content) that was never reconciled with the convention (-icon/-section) used elsewhere.Fix
Renamed the two classes to match the established convention (2-line diff in
settings-popup.html).Test plan
npm run test:all— 6866 passed, 0 failednpm run lint— 0 errors (pre-existing warnings unrelated to this file)