feat: add number_of_employees field to Profile API - #388
Draft
Jai Shankar (jaishankar-plivo) wants to merge 1 commit into
Draft
feat: add number_of_employees field to Profile API#388Jai Shankar (jaishankar-plivo) wants to merge 1 commit into
Jai Shankar (jaishankar-plivo) wants to merge 1 commit into
Conversation
Add an optional number_of_employees string field to the Profile (10DLC/A2P) create and update APIs, mirroring the existing doing_business_as field. The field is not validated client-side (the server validates the allowed values); the 7 allowed values are documented in JSDoc/type-def comments. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new optional
number_of_employeesstring field to the Profile (10DLC/A2P account profile) create and update APIs. This mirrors a backend change in campaign-service wherenumber_of_employeeswas added to the Profile create & update request as an optional string.The field is implemented exactly like the recently-added
doing_business_as(DBA) field — same files, positions (right after DBA), and style.Details
.d.tscomments:BETWEEN_1_AND_10,BETWEEN_11_AND_50,BETWEEN_51_AND_200,BETWEEN_201_AND_500,BETWEEN_501_AND_2000,BETWEEN_2001_AND_10000,MORE_THAN_10001.Changes
lib/resources/profile.js— addednumber_of_employeescreate param + JSDoc (create & update).types/resources/profile.d.ts— added optionalnumber_of_employeesto create signature and update params type.test/profile.js— assertion on get-profile fixture + positional arg in create test.lib/rest/request-test.js— addednumber_of_employeesto the GET profile fixture.package.json— version bump4.77.1->4.77.2.CHANGELOG.md— new top entry.🤖 Generated with Claude Code