Skip to content

feat: expose sub_account_name on Number resource - #264

Merged
avinashp-plivo merged 3 commits into
masterfrom
FNT-370
May 26, 2026
Merged

feat: expose sub_account_name on Number resource#264
avinashp-plivo merged 3 commits into
masterfrom
FNT-370

Conversation

@avinashp-plivo

Copy link
Copy Markdown
Contributor

Summary

  • Adds sub_account_name to the Number#to_s output so it shows up alongside sub_account when the resource is printed.
  • The attr_reader for @sub_account_name is already created dynamically by Base::Resource#parse_and_set once the API returns the field, so this is purely a to_s parity tweak.
  • Mock responses (numberGetResponse.json, numberListResponse.json) updated to include sub_account_name; the spec's to_json helper updated to mirror.

Mirrors the parallel work on plivo-java#317, plivo-php#371, plivo-dotnet#312 for FNT-370.

Test plan

  • bundle exec rspec spec/resource_numbers_spec.rb passes locally (5/5)
  • Updated mocks contain the new field for both get and list cases

🤖 Generated with Claude Code

avinashp-plivo and others added 2 commits May 25, 2026 13:47
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@avinashp-plivo
avinashp-plivo merged commit 6dcdf56 into master May 26, 2026
8 of 11 checks passed
@avinashp-plivo
avinashp-plivo deleted the FNT-370 branch May 26, 2026 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants