add better handling for typescript compiler

[Jordan-Hall]

fix: soft file there is no props defined

Check if export is either a class or function that returns JSX element
This allows for none exported JSX functions in the file.

For example if you had the following file:

import React from "react";
import DropdownArrowDown from '../dropdownArrowDown';
import { AutoCompleteOptions, AutoCompleteValue, RealAutoCompleteOptions } from "./types";


export interface AutoCompleteTypes {
    id: string;
    autoselect: boolean;
}

export const autoCompleteDefaultProps: Partial<AutoCompleteTypes> = {
    autoselect: false,
};


export const AutoComplete = (props:AutoCompleteTypes) => {...}

The export default would crash and file due to not having props. Now it will check its a function or a class before trying to convert to dash py

[Jordan-Hall]

@T4rk1n before i carry on and add Unit test for these. This is what I was thinking to solve #2066 (comment). The error comes from not checking the type is related to JSX before trying to work out the props.

export const defaultProps = {
   address: "abc...."
}

would cause the complier to break. So while i was at it, i thought its best to check the return type is an element. If this is ok, I'll take a look at how to add support for multiple components in a single file. Currently you always override the docs each time which isn't ideal

[Jordan-Hall]

The failed unit test relates to JSX just returning null. In real world I can't ever expect it not to be Element. But happy to remove that extra check for JSX

[T4rk1n]

@T4rk1n before i carry on and add Unit test for these. This is what I was thinking to solve #2066 (comment). The error comes from not checking the type is related to JSX before trying to work out the props.

export const defaultProps = {
   address: "abc...."
}

would cause the complier to break. So while i was at it, i thought its best to check the return type is an element. If this is ok, I'll take a look at how to add support for multiple components in a single file. Currently you always override the docs each time which isn't ideal

The failed unit test relates to JSX just returning null. In real world I can't ever expect it not to be Element. But happy to remove that extra check for JSX

Seems ok, just make sure that null is also a valid return type, some components don't need to render anything (eg: dcc.Store) and thus return null.

[gvwilson]

@T4rk1n can you please take another look at this one in cycle 17? thanks - @gvwilson

[Jordan-Hall]

I'm happy to take a look and make any changes