fix: name the WooCommerce integration row (#146) - #147
Merged
Conversation
Saddle Pro's saddle_integration_ui_prefixes hook contributes four detection-gated prefixes, not three: yoast-, rank-math-, aioseo- and wc-. #144 gave KNOWN display entries to the three SEO ones and missed the store, so a Pro + WooCommerce site rendered a row titled literally "wc" with an empty description via detectIntegrations()'s fallback. Also regenerates languages/saddle.pot, which was last built on 08-21 and so was missing #144's six SEO msgids alongside these two. Closes #146
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #146
What
Adds a
WooCommercedisplay entry toKNOWNin the Integrations screen, and regenerateslanguages/saddle.pot.Why
Saddle Pro's
saddle_integration_ui_prefixeshook contributes four detection-gated prefixes, not three —yoast-(7 tools),rank-math-(5),aioseo-(3) andwc-(9). #144 gave display entries to the three SEO ones and missed the store, so on a Pro + WooCommerce site the "Detected integrations" panel rendered a row titled literallywcwith an empty description, viadetectIntegrations()'s{ title: key, description: '' }fallback. Same symptom class as therankrow #143 fixed, reached through the missing-entry path rather than the prefix split.How
wc-check-setupsplits totwo === 'wc-check', which isn't inKNOWN, soparts[0]→wcis the key registered. The two-segment prefix logic needed no change.saddle_pro_integration_ui_prefixes()only pusheswc-whileSaddle_Pro_WC::is_active(), so no WooCommerce, no row..potwas last generated 2026-08-21 and so was stale by fix: display the native Pro SEO integrations on the Integrations screen (#143) #144's six SEO msgids as well as these two. Regenerated with the same toolchain the header records (WP-CLI 2.12.0); the diff is purely additive — eight new msgids, zero removals, no header or version change.Testing
npm run lint:js— cleannpm run build— bundle rebuilt, tracked output committed; only the pre-existing bundle-size warnings.potregeneration verified reproducible: regenerating against the pre-change tree reproduces the committed file byte-for-byte apart fromPOT-Creation-Date, so the exclude list is the one that produced itsaddle-pro.php:313→class-saddle-rest.php:937→Integrations.jsx)No PHP changed. The repo's PHPUnit suite currently fails on
mainfor an unrelated reason (build-page playbook text assertion, 612 tests / 1 failure); this branch does not affect it.🤖 Generated with Claude Code
https://claude.ai/code/session_01FMkAKieoLrMcY7aoYhCwzt