Skip to content

fix: name the WooCommerce integration row (#146) - #147

Merged
ifahimreza merged 1 commit into
mainfrom
fix/146-integrations-wc-row
Aug 24, 2026
Merged

fix: name the WooCommerce integration row (#146)#147
ifahimreza merged 1 commit into
mainfrom
fix/146-integrations-wc-row

Conversation

@ifahimreza

Copy link
Copy Markdown
Contributor

Closes #146

What

Adds a WooCommerce display entry to KNOWN in the Integrations screen, and regenerates languages/saddle.pot.

Why

Saddle Pro's saddle_integration_ui_prefixes hook contributes four detection-gated prefixes, not three — yoast- (7 tools), rank-math- (5), aioseo- (3) and wc- (9). #144 gave display entries to the three SEO ones and missed the store, so on a Pro + WooCommerce site the "Detected integrations" panel rendered a row titled literally wc with an empty description, via detectIntegrations()'s { title: key, description: '' } fallback. Same symptom class as the rank row #143 fixed, reached through the missing-entry path rather than the prefix split.

How

  • wc-check-setup splits to two === 'wc-check', which isn't in KNOWN, so parts[0]wc is the key registered. The two-segment prefix logic needed no change.
  • Honesty of the panel is unchanged and still enforced on the Pro side: saddle_pro_integration_ui_prefixes() only pushes wc- while Saddle_Pro_WC::is_active(), so no WooCommerce, no row.
  • The .pot was last generated 2026-08-21 and so was stale by fix: display the native Pro SEO integrations on the Integrations screen (#143) #144's six SEO msgids as well as these two. Regenerated with the same toolchain the header records (WP-CLI 2.12.0); the diff is purely additive — eight new msgids, zero removals, no header or version change.

Testing

  • npm run lint:js — clean
  • npm run build — bundle rebuilt, tracked output committed; only the pre-existing bundle-size warnings
  • .pot regeneration verified reproducible: regenerating against the pre-change tree reproduces the committed file byte-for-byte apart from POT-Creation-Date, so the exclude list is the one that produced it
  • Not exercised against a live Pro + WooCommerce install — verified by reading the wiring on both sides (saddle-pro.php:313class-saddle-rest.php:937Integrations.jsx)

No PHP changed. The repo's PHPUnit suite currently fails on main for an unrelated reason (build-page playbook text assertion, 612 tests / 1 failure); this branch does not affect it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FMkAKieoLrMcY7aoYhCwzt

Saddle Pro's saddle_integration_ui_prefixes hook contributes four
detection-gated prefixes, not three: yoast-, rank-math-, aioseo- and wc-.
#144 gave KNOWN display entries to the three SEO ones and missed the
store, so a Pro + WooCommerce site rendered a row titled literally "wc"
with an empty description via detectIntegrations()'s fallback.

Also regenerates languages/saddle.pot, which was last built on 08-21 and
so was missing #144's six SEO msgids alongside these two.

Closes #146
@ifahimreza ifahimreza linked an issue Aug 24, 2026 that may be closed by this pull request
@ifahimreza
ifahimreza merged commit d20573c into main Aug 24, 2026
1 of 7 checks passed
@ifahimreza
ifahimreza deleted the fix/146-integrations-wc-row branch August 24, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrations screen: WooCommerce renders as a row named "wc"

1 participant