feat(admin): move the brand accent to #DA5CC7 (#157) - #158
Merged
Conversation
Straight swap of the palette's brand hue, but not a straight swap of every token that used it, because the new colour cannot do everything the old one could. #DA5CC7 is 3.31:1 on white. That clears the 3:1 a mark or a fill needs and misses the 4.5:1 text needs — so it is the brand colour exactly as given wherever a fill belongs (dots, the focus ring, the active nav row, bar fills), and the readable step of the same hue carries every label. The violet it replaces cleared both at 5.84, which made --pp-accent and --pp-accent-text nearly interchangeable and hid how load-bearing that split is; here it is doing real work. Primary buttons take #BD2BA7 rather than the brand colour itself. White on #DA5CC7 is 3.31:1 — a button label people cannot read. White on #BD2BA7 is 5.16. The tint is #FDF4FC rather than something more saturated because an accent dot on the accent tint needs 3:1, and a #FBECF9 wash gave 2.91. Verified: white on the button 5.16, white on hover 6.24, link on the page 4.99, link on the tint 4.80, focus ring on the page 3.20, accent dot on the tint 3.08. Every gate the palette is held to still passes. DESIGN-ALIGNMENT.md and the readme changelog updated with it, and the prose that named the colour now names the role instead, so the next change of hue is a token edit rather than a documentation sweep. 645 tests, 0 lint errors. Closes #157
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #157
What
Swaps the brand hue from
#6D3BF5to#DA5CC7.Why it isn't a one-line swap
#DA5CC7measures 3.31:1 on white — above the 3:1 a mark or fill needs, below the 4.5:1 text needs. So it can be seen but not read, and it cannot be the ground under a white button label either (also 3.31:1).That is exactly the fill/text split the palette was already built around. The violet happened to clear both at 5.84:1, which made
--pp-accentand--pp-accent-textnearly interchangeable; this colour makes the distinction do real work.--pp-accent#DA5CC7--pp-accent-text#BD2BA7--pp-accent-hover#A82595--pp-accent-tint#FDF4FC--pp-action#BD2BA7--pp-focus#DA5CC7The tint is
#FDF4FCrather than something more saturated because an accent dot sitting on the accent tint needs 3:1, and a#FBECF9wash gave 2.91.Verified
Confirmed in the browser too — computed
--pp-accent#da5cc7, button groundrgb(189,43,167)with white text, brand markrgb(218,92,199).composer test— 645 tests, 0 failurescomposer lint·npm run lint:js— 0 errorsnpm run build,.potregeneratedAlso
DESIGN-ALIGNMENT.mdand the readme changelog updated. The prose that named the colour now names the role, so the next change of hue is a token edit rather than a documentation sweep — the one remaining mention of violet is a deliberate historical note explaining why the split matters more now.Note
rc9 is already live on the self-hosted channel with the violet. This lands in the next build; say the word if you want an rc10 cut.
CI note:
mainis red on #145 (CI-only). This branch inherits it.