Skip to content

Polish Pure Light mode surfaces without changing dark mode - #4061

Merged
michaeljguarino merged 4 commits into
masterfrom
pure-light-mode-update
Aug 27, 2026
Merged

Polish Pure Light mode surfaces without changing dark mode#4061
michaeljguarino merged 4 commits into
masterfrom
pure-light-mode-update

Conversation

@wailingwombat

Copy link
Copy Markdown
Collaborator

Summary

  • Updates light-mode semantic tokens, elevated surfaces, shadows, and component styling to match the Pure Light look (white/grey fills, softer borders, lighter table zebra rows).
  • Gates light-only overrides behind theme.mode === 'light' so dark mode behavior and appearance stay unchanged.
  • Makes user avatars consistently circular in the header, profile sidebar, and user management lists via Avatar theme defaults and a new AppIcon rounded prop.

Test plan

  • Toggle between light and dark mode — dark should match current production
  • Light mode: home workbenches banner, header dropdowns, stacks side nav, tabs, tables, and chat input surfaces look white/grey per Pure Light
  • Profile menu avatar, profile sidebar avatar, and user management list avatars are circular in both themes
  • Workbench prompt mode selector and side panel look correct in both themes

Made with Cursor

@wailingwombat
wailingwombat requested a review from a team as a code owner August 26, 2026 20:18
@soffi-ai

soffi-ai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Soffi AI Summary

This PR polishes the "Pure Light" theme across the Console design system without touching dark mode behavior. The changes update light-mode semantic tokens, elevated surface treatments, shadows, border handling, and component styling (cards, buttons, tabs, inputs, chips, code blocks, selects, sidecars, etc.) to produce white/grey fills and softer borders consistent with the Pure Light visual spec. All light-mode overrides are gated behind theme.mode === 'light' checks so dark mode appearance is completely unchanged. Additionally, user avatars are made consistently circular in all contexts (header, profile sidebar, user management lists) via Avatar theme defaults and a new AppIcon rounded prop. The PR also adds a library of programming language/brand logo icons (Go, Python, TypeScript, JavaScript, Java, Rust, Ruby, C#, C++, PHP, Scala, Elixir) used by a new codeLanguageIcons utility.

Changes

Pure Light mode surface polish

  • Applied Pure Light semantic tokens and light-mode surface styling across Card, Button, Tab, Input, Select, Chip, Code, InlineCode, Markdown, Sidecar, and IconFrame components. Elevated surfaces gain box-shadow and backgroundClip fixes; all overrides are gated behind theme.mode === 'light' to leave dark mode untouched. Also introduced the RustLogoIcon and a batch of programming-language logo icons (Go, Python, TypeScript, JavaScript, Java, Ruby, C#, C++, PHP, Scala, Elixir), plus a codeLanguageIcons utility mapping. (c5108a1)
  • Continued light-mode surface refinement: Card's OuterWrapSC now owns the single box-shadow for header+body card combinations, overflow handling is corrected to avoid clipping shadows, and AppIcon gains a rounded prop to make user avatars consistently circular across the header, profile sidebar, and user management list in both themes. (db7cabc)
  • Minor follow-up tweaks to light mode styling — small visual corrections identified after initial review of the Pure Light pass. (c0216ea)
  • Additional light-mode fixes addressing remaining visual inconsistencies found during testing, including PopoverListBox and ListBox border/background adjustments and GlobalStyle baseline overrides for light mode. (337751f)

Updated: 2026-08-27 04:05 UTC

Deploy in Soffi

@greptile-apps

greptile-apps Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR refreshes light-mode surfaces while preserving explicit dark-mode styling and standardizes circular user avatars.

  • Adds light-mode semantic surface, border, shadow, page-background, and table-row tokens.
  • Applies elevated light surfaces and revised overflow handling across shared controls, cards, menus, charts, and feature layouts.
  • Adds circular avatar defaults and an AppIcon rounded option used by profile and user views.
  • Keeps workbench, chat, navigation, table, and shell surfaces mode-aware.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete blocking or independently actionable issue identified in the changed paths.

The mode-specific token changes preserve explicit dark mappings, affected controls retain focus indicators, and layout changes continue to provide clipping or scrolling at the appropriate parent or descendant boundary.

Important Files Changed

Filename Overview
assets/design-system/src/components/Card.tsx Adds light-mode elevation and visible overflow for card shadows; reviewed representative clipping-sensitive callers without finding a concrete regression.
assets/design-system/src/theme/colors-semantic-light.ts Reworks light semantic fills, raised states, and borders into a white and soft-grey surface hierarchy.
assets/design-system/src/components/table/colors.ts Introduces mode-aware raised and selected row colors while preserving the legacy dark mappings.
assets/src/components/cost-management/CostManagement.tsx Moves padding inside the existing bounded scroll container so light card shadows have room to render.
assets/src/components/cost-management/CostManagementChartView.tsx Delegates scrolling to the parent cost-management wrapper and adds responsive wrapping and local chart clipping.
assets/design-system/src/components/AppIcon.tsx Adds an opt-in circular border radius used for user avatars.
assets/src/components/layout/ProfileMenu.tsx Makes the profile trigger circular and adds mode-specific avatar hover and initials styling.
assets/src/components/ai/chatbot/input/ChatInput.tsx Resolves the default chat-input background by mode and preserves custom backgrounds during focus.
assets/src/components/utils/sidebar/SidebarItem.tsx Derives softer light-mode navigation hover and active fills while leaving dark-mode token behavior intact.

Reviews (1): Last reviewed commit: "Polish Pure Light surfaces, preserve dar..." | Re-trigger Greptile

@wailingwombat wailingwombat added frontend Changes related to the frontend design-system has design system changes labels Aug 26, 2026
wailingwombat and others added 3 commits August 26, 2026 17:01
Bake Pure Light fills/borders into default light semantic colors and gate elevated surfaces, shadows, and overflow fixes to light mode so dark mode stays unchanged.

Co-authored-by: Cursor <cursoragent@cursor.com>
Light-mode-only table zebra, shadows, and surface overrides; dark regressions reverted. User avatars are circular in header, profile sidebar, and user lists via Avatar theme and AppIcon rounded prop.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

@michaeljguarino michaeljguarino added enhancement New feature or request and removed design-system has design system changes labels Aug 26, 2026
@michaeljguarino

Copy link
Copy Markdown
Member

plural deploy this

@plural-copilot

Copy link
Copy Markdown
Contributor

Requested GitOps deployment update created: https://github.com/pluralsh/plrl-up-demos/pull/2714

It pins console to sha-09bc5f9 (commit 09bc5f9495a15bf58c4db7b21fd0e3c8ee121b14).

@michaeljguarino

Copy link
Copy Markdown
Member

plural deploy this

@plural-copilot

Copy link
Copy Markdown
Contributor

GitOps deployment PR: https://github.com/pluralsh/plrl-up-demos/pull/2715 — pins the demo console image to sha-1132ec3 from source commit 1132ec3251213c370cfd44ffa48cfbe7539e747d.

@michaeljguarino
michaeljguarino merged commit 7e0c422 into master Aug 27, 2026
16 checks passed
@michaeljguarino
michaeljguarino deleted the pure-light-mode-update branch August 27, 2026 04:16
@michaeljguarino

Copy link
Copy Markdown
Member

plural deploy this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend Changes related to the frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants