report Yaksa autogen depth in mpichversion - #7914
Merged
Merged
Conversation
Member
Author
|
I accept that this may not be your preferred method for implementing this, particularly since non-expert users might be confused and thing |
Issue pmodels#6677 points out that the top-level ./autogen.sh -yaksa-depth=N choice can materially affect the generated Yaksa pack/unpack code, but the value was not visible later from mpichversion. Since mpichversion already reports the configure argument string, record the selected autogen Yaksa depth in a small m4 file and prepend it to CONFIGURE_ARGS_CLEAN as -yaksa-depth=N. This keeps the user-facing output in the existing MPICH configure field, which matches the request to display the autogen choice as if it were a configure option. The default tracked value is 2, matching autogen.sh's current default. Full Yaksa autogen runs update the file after the Yaksa autogen command succeeds, so non-default ./autogen.sh -yaksa-depth=N runs propagate the selected value into the generated configure script. Verified by regenerating with ./autogen.sh --without-fortran --without-test, configuring a fresh GCC build directory with CC=gcc CXX=g++ using --disable-fortran --disable-cxx --with-device=ch4:ofi --with-libfabric=embedded --enable-g, and building with make -j50. The resulting build-gcc-fix-issue-6677/src/env/mpichversion -configure output includes -yaksa-depth=2 ahead of the configure options. git diff --check is clean.
Collaborator
|
I pushed a few modifications:
|
The "-yaksa-depth" is an autogen option. Listing it as configure option may mislead users. Rather, show yaksa in the feature list.
Have each backend's genpup.py write an autogen_info file recording the pup-max-nesting depth. Yaksa's configure reads these files, assembles MPICH_YAKSA_INFO (e.g. "seq(depth=2) cuda(depth=2)"), and exports it via localdefs for MPICH to consume.
Replace the m4_include of maint/yaksa_depth.m4 with MPICH_YAKSA_INFO exported from yaksa's localdefs. The feature string now shows per-backend depth, e.g. "yaksa(seq(depth=2) cuda(depth=2))".
Collaborator
|
@jeffhammond Please review |
Member
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #6677 points out that the top-level
./autogen.sh -yaksa-depth=Nchoice can materially affect the generated Yaksa pack/unpack code, but the value was not visible later frommpichversion. Sincempichversionalready reports the configure argument string, record the selectedautogenYaksa depth in a small m4 file and prepend it to CONFIGURE_ARGS_CLEAN as-yaksa-depth=N. This keeps the user-facing output in the existing MPICH configure field, which matches the request to display the autogen choice as if it were a configure option.The default tracked value is 2, matching autogen.sh's current default. Full Yaksa autogen runs update the file after the Yaksa autogen command succeeds, so non-default ./autogen.sh -yaksa-depth=N runs propagate the selected value into the generated configure script.
Verified by regenerating with
./autogen.sh --without-fortran --without-test, configuring a fresh GCC build directory withCC=gcc CXX=g++ using --disable-fortran --disable-cxx --with-device=ch4:ofi --with-libfabric=embedded --enable-g, and building withmake -j50. The resultingbuild-gcc-fix-issue-6677/src/env/mpichversion -configure outputincludes-yaksa-depth=2ahead of the configure options.Pull Request Description
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
Resolves #6677