Fortran: fix mapping of Fortran REAL - #7918
Merged
Merged
Conversation
Collaborator
Author
|
test:mpich/ch3/most |
colleeneb
approved these changes
Aug 3, 2026
colleeneb
left a comment
colleeneb
left a comment
Collaborator
There was a problem hiding this comment.
I had one not-super-important comment, but it looks good. I built it and tested with the reproducer and it worked.
|
|
||
| if (rank .eq. 0) then | ||
| ans_f = real(size * (size + 1) / 2) | ||
| if (abs(sum_f - ans_f) .gt. 1.0e-6) then |
Collaborator
There was a problem hiding this comment.
1.0e-6 might be a little tight for comparing reals generally (maybe 1e-5 or 1e-4 would be better) but since this is just comparing the sum of ranks it's probably rare it would be a problem.
1 task
A typo resulted mapping Fortran REAL to internal integer type.
Add basic tests that covers reduce operation on basic Fortran types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fix a typo in configure resulted mapping Fortran
REALto internalMPIR_INT32.Add a test cover future mapping issues.
Fixes #7911
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.