setup action: police its own uses: ref like aggregate does - #68
Merged
Conversation
The aggregate action's ref check (#57) closed the unguarded-literal problem for one action; consumers adopting actions/setup@<rev> would reintroduce it on the other. The setup action already reads the Cargo.lock pin, so the comparison is one step: a 40-hex action ref that differs from the pin fails; branch/tag/local refs (this repo's own smoke uses ./actions/setup) skip with a notice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends #57's ruling to the second action:
actions/setupalready derives the pin from the consumer's Cargo.lock, so it now comparesgithub.action_refagainst it — fail on 40-hex skew, notice-and-skip for branch/tag/local refs (the in-repo smoke uses./actions/setup). Without this, adoption PRs pinningsetup@<rev>would carry exactly the unguarded literal the aggregate check just removed.