Skip to content

js: key the page runner's report by target, not suite #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lann merged 1 commit into from
Aug 7, 2026
Merged

js: key the page runner's report by target, not suite #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions js/viewer/page-runner.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,14 @@ function runShard(workerUrl, config, shard, onRow) {
}

/**
* Run every configured suite and report. `suites` entries carry the
* browser-worker run message minus `shard` (moduleUrl, coreUrls,
* importsUrl, contextUrl?, env?, missing?, caseTimeoutMs?) plus
* `suite` (the results identity) and `target`. `jobs` defaults to the
* capped hardware parallelism; pass 1 for sequential corpora.
* Run every configured suite and report, keyed by `target` — the one
* identity unique per run (several targets may run one suite, e.g. a
* plain and a delegated composition of the same corpus). `suites`
* entries carry the browser-worker run message minus `shard`
* (moduleUrl, coreUrls, importsUrl, contextUrl?, env?, missing?,
* caseTimeoutMs?) plus `suite` (the results identity in the envelope)
* and `target`. `jobs` defaults to the capped hardware parallelism;
* pass 1 for sequential corpora.
*/
export async function runSuitesInPage({ workerUrl, suites, jobs }) {
const pool = jobs ?? workerCount(navigator.hardwareConcurrency ?? 4);
Expand All @@ -68,7 +71,7 @@ export async function runSuitesInPage({ workerUrl, suites, jobs }) {
);
const events = shards.flatMap((s) => s.events);
events.sort((a, b) => a.index - b.index);
out[suite] = {
out[target] = {
lines: [
JSON.stringify(envelope(target, suite)),
...events.map((e) => JSON.stringify(e.event)),
Expand Down
Loading