js: caller-owned report keys in the page runner; only passthrough - #73
Merged
Conversation
Designing the three browser adoptions completed the key space: one suite runs as several targets (tls: plain and delegated compositions) and one target runs several suites (webcrypto: main and signing corpora), so neither is unique on its own — the report key belongs to the caller, defaulting to the target. The worker also forwards runCases' only filter, which it already accepted everywhere else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the keying design from #72 with the full consumer space in view: tls runs one suite as two targets, webcrypto runs two suites under one target — neither identity is unique alone, so the report key is caller-owned (
key, defaulttarget; existing consumers unaffected). The browser worker also forwardsrunCases'onlyfilter it already accepted from every other entry point.