js: browser launch arguments on runPageHarness - #74
Merged
Conversation
The websocket consumer's browser leg provisions trust for its committed test PKI with --ignore-certificate-errors and carries the container sandbox flags; the launcher now takes launchArgs through to the engine (both engines; Playwright forwards args uniformly).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumer-driven addition for the websocket browser adoption: its leg needs
--ignore-certificate-errors(committed test PKI, loopback-only instance) and the container sandbox flags at launch.launchArgspasses through to the engine on both branches; absent means today's behavior.