Add the jco-node conformance targets - #33
Merged
Merged
Conversation
The upstream ladder is resolved (lann/jco#34 -> #35 -> #40 -> #11, fix/concurrent-task-lifetimes being the final piece), verified end-to-end on the all-fixes-dbad4d7 pre-release: the composed artifacts now run under Node 24 JSPI. Two new standing targets transpile the same compositions the wasmtime rows run — one suite, one composition, two engines: - driver-ct/jco: the transpiles (component-test-jco-transpile bin, -I async, no SUT host module — the artifacts import only wasi 0.2 and test-context) and a lean run-node driver on the upstream harness core and ./imports builder; fresh instance per case (JSPI attempts cannot be cancelled). The tags custom section rides the suite's core module through wac composition and transpilation, so scheduling reads straight from the composed cores. - targets.toml: jco-node (missing delegated-signer) and jco-node-delegated rows; browser rows stay deferred behind the shared page driver (#32, upstream polymorph-test#59). - The jco tree's lockfile joins the pins gate and the setup action's js-locks; CI gains Node 24 with npm caching; the aggregate action publishes the two new columns. The transpiler/shim pins are the lann/jco all-fixes-dbad4d7 release tarballs — rev-exact like every other pin, bumped deliberately as the fork advances. Verified: just conformance green (5 targets, 28 results, 0 failing; committed matrix updated with the two columns); just check green. Fixes #28.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28. The upstream defect ladder this issue tracked is fully resolved — lann/jco#34 (TDZ) → #35 (return-position transfer) → #40 (delivery hang) → #11 (
fix/concurrent-task-lifetimes) — and verified end-to-end on theall-fixes-dbad4d7pre-release tarballs, which lann now publishes per all-fixes push (the consumability gate from the issue thread). The composed smoke artifact runs its full loopback clean under Node 24 JSPI, so the targets land:jco-node/jco-node-delegated: the same composed artifacts the wasmtime rows run, transpiled (component-test-jco-transpile,-I async) and driven by a leanrun-node.mjsover the upstream harness core +./importsbuilder (polymorph-test#58's glue — no SUT host module exists on this leg at all; the artifacts import only wasi 0.2 + test-context). Fresh instance per case, per the JSPI-cancellation caveat. Tag scheduling reads from the composed cores directly — the tags custom section demonstrably surviveswac plug+ transpilation, so no--suite-artifactsidecar is needed on this leg.package-lock.jsonjoins thepinsgate and the setup action'sjs-locks; the Cargo.toml bump procedure gains the--package-jsonflag.Verified locally:
just conformance(5 targets, 28 results, 0 failing, matrix diff clean),just check, plus the raw driver runs showing per-case verdicts under Node.