Add the jco-browser conformance targets on the upstream page driver - #35
Merged
Conversation
The pin moves to 2436bb9 via pins bump, picking up polymorph-test#71 and #72 — the browser page driver (#59's browser half), of which this repository is the first consumer: run-browser.mjs is only the frame (core-URL enumeration, target configuration, results writing) over the upstream buildHarnessPage/runPageHarness/findChrome, the in-page pool, and the generic shard worker; browser-imports.mjs supplies the import object by server path (module workers cannot see import maps — the harness core arrives through the driver's self-mount, the wasi shims through this tree's node_modules). Two optional targets: jco-browser and jco-browser-delegated gate in CI (the Actions image ships Chrome) and run locally under CONFORMANCE_BROWSER=1. The committed matrix grows to seven columns — identical verdicts across wasmtime, Node/JSPI, and Chromium. Verified: CONFORMANCE_BROWSER=1 just conformance green (7 targets, 42 results, 0 failing); just check green. Fixes #32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32. First consumer of polymorph-test#71/#72 (the #59 browser half) — the seam test that design was deferred for, and it held:
run-browser.mjsis pure frame (~90 lines): core-URL enumeration, the two target configs, results writing via./node-runner. Everything else — page HTML, import-map/self-mount, worker pool, suite-order restoration, heartbeat/stall watchdog, Chrome ladder — is the upstream./browser-driver+ in-page modules.browser-imports.mjsis the one genuinely local browser piece: the import object by server path (workers can't see import maps; harness core via the driver's/__component-testself-mount, fork preview2-shim via this tree'snode_modules/…/dist/browser/).jco-browser+jco-browser-delegated,optional = true— gate in CI (system Chrome on the runner image), local opt-inCONFORMANCE_BROWSER=1, stale-results cleared on the skip path (the webcrypto predicate pattern).Verified locally with the browser leg:
CONFORMANCE_BROWSER=1 just conformance— 7 targets, 42 results, 0 failing, committed matrix updated;just check.