ci: install just in the webkit jobs via the pinned binstall bootstrap - #343
Merged
Conversation
The two wpt-parity-webkit jobs installed just by piping just.systems/install.sh into bash: version-pinned but a floating, unverified script — the same shape #342 removed from setup.sh. The comment's excuse ("this job skips the Rust toolchain, so it cannot use setup.sh's cargo-binstall path") turns out to be false: binstall's prebuilt strategy needs no cargo at all. setup.sh's digest-verified bootstrap moves to scripts/install-binstall.sh, shared by setup.sh and the two jobs, which now install just with cargo-binstall --disable-strategies compile (fail closed rather than presume a toolchain). just's own bytes stay trusted via crates.io metadata + GitHub TLS, like every other binstall-installed tool; byte-pinning the tools themselves is the still-open half of #34.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two wpt-parity-webkit jobs installed
justby pipingjust.systems/install.shinto bash — version-pinned (--tag 1.54.0) but a floating, unverified script (it has no checksum logic), the same shape #342 removed from setup.sh.The old comment's justification — "this job skips the Rust toolchain, so it cannot use setup.sh's cargo-binstall path" — is empirically false: cargo-binstall's prebuilt strategy needs no cargo. So setup.sh's digest-verified bootstrap moves to
scripts/install-binstall.sh(byte-for-byte the same block, plus the idempotence guard), shared by setup.sh and the two webkit steps, which now run it and thencargo-binstall --no-confirm --disable-strategies compile --install-path ~/.local/bin just@1.54.0— compile fallback disabled, so a missing toolchain fails closed instead of being assumed.Scope note:
just's own release bytes remain trusted via crates.io metadata + GitHub TLS, exactly like every other binstall-installed tool (wasm-tools, wac, wasmtime); byte-pinning tool artifacts is the still-open half of #34's checklist. This PR removes the mutable-script layer and unifies the fleet on one verified bootstrap.Verification:
install-binstall.shinstalls the digest-verified 1.21.1, then binstall installsjust 1.54.0into~/.local/binin ~2s