Move componentize-js to the lann fork and adopt its eager-settlement fix - #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two co-dependent steps, one ruling: componentize-js is now sourced from
the lann/componentize-js fork, at a pin that includes the fork's fix.
Repoint references — the toolchain workflow's clone URL, the library
and demo READMEs, and the shim header now name lann/componentize-js
(a fork of dicej/componentize-js). Deliberately unchanged: the
dicej/componentize-js#5citation (the PR lives on the parent repo; thefork has no PR 5) and the "(dicej's ComponentizeJS reboot)" provenance
attributions in
AGENTS.md/js/componentize/justfile.Bump the pin to
f417fa6d5f74, the fork's head: it mergeslann/componentize-js#1,
which routes the eager (returned-immediately) async-import path through
the same ok/err discrimination as the suspending path, so
result<>-typedimports settle spec-shaped instead of resolving with the raw
{ tag, val }wrapper. This library already normalized both settlementshapes (
callImport), so its behavior is unchanged — the README's"upstream quirk" paragraph and the
callImportdoc now describe the fixas included in the pin. The bump is what makes the fix available to
consumers without such normalization, e.g. the websocket sibling's shim
(see polymorph-components/polymorph-websocket#31).
The bump depends on the repoint:
f417fa6is reachable only from thefork, so the workflow's clone must already name it.
Toolchain mechanics: the workflow built and published the (rev, platform)
assets from this branch, and
just componentize::update-toolchain-digestrecorded their digests after verifying the build-provenance attestations
(subject digest, building repository, and workflow path all checked).
Verified locally on the new toolchain:
just componentize::test(19/19checks) and
just wpt::test(all in-subset groups pass; censusunchanged, so no
wpt::update-expectationsneeded).