Migrate TODO.md to GitHub issues - #129
Merged
Merged
Conversation
Each open item moves to its own issue (A3->#119, E6->#120, E12->#121, E14->#122, E15->#123, E16->#124, E18->#125, F5->#126, F7->#127, F11->#128); references in Cargo.toml, wasip3-impl/README.md, conformance/manifests.toml (including the wasip3-guest-x-reference expected-fail tracking ref), conformance/README.md, cli-signaling.rs, and the runner's schema docs and test fixtures now point at issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves every open
TODO.mditem to its own GitHub issue, deletesTODO.md, and updates all references to point at the issues.rtcgit pin)Issue bodies carry the TODO text verbatim (intra-TODO cross-references converted to issue links; #125 also links the pre-existing #117) and a "Migrated from
TODO.mditem " footer, so the ids referenced by older commits and PRs stay traceable.Reference updates
conformance/manifests.toml: thewasip3-guest-x-referenceexpected-failtrackingref now points at rtc emits no SCTP stream reset on data-channel close #123; the schema comment's example tracking ref is now "a GitHub issue URL" (alsoconformance/README.md×2 and the runner'sExpectedFail::trackingdoc).Cargo.toml: thertc[patch.crates-io]comment points at Unwind the rtc git pin once upstream ships a release #120 (and no longer names the deleted E4 item for the srflx finding).wasip3-impl/README.md: the pin-unwinding pointer is now Unwind the rtc git pin once upstream ships a release #120.examples/wasmtime-demo/src/bin/cli-signaling.rs: the close-linger comment points at Replace the bounded close-drain graces with flush-aware teardown #126.conformance/runner/src/main.rs: test-fixture tracking strings no longer name TODO.md.Verification
rg 'TODO\.md|TODO item'finds no remaining references.just fmt-check,just clippy, and the conformance-runner tests (13/13) pass.