Master noble fixed - #1827
Open
siddhpant wants to merge 9 commits into
Open
Conversation
This reverts commit 7898b65. GNOME 49+ support is a breaking change for older versions. Signed-off-by: Siddh Raman Pant <25429745+siddhpant@users.noreply.github.com>
This reverts commit 3cb093b. GNOME 49+ support is a breaking change for older versions. Signed-off-by: Siddh Raman Pant <25429745+siddhpant@users.noreply.github.com>
…nd added gnome 49 shell version in metadata" This reverts commit d22d2ff. GNOME 49+ support is a breaking change for older versions. Signed-off-by: Siddh Raman Pant <25429745+siddhpant@users.noreply.github.com>
The first window is fully maximized, and then later when a second window is opened, we don't get border for the first window when it is in focus because after tiling the first window has stale value for smart_gapped, and thus is_single_max_screen() returns true, causing permitted in show_border() to be false. Let's set smart_gapped for each window in a tree each time we tile. Closes: pop-os#1758 Signed-off-by: Siddh Raman Pant <25429745+siddhpant@users.noreply.github.com>
It caused GNOME crash due to bug in mutter, which was fixed in v49. But regardless, we should not spam the close signal. Also people might be using versions before 49. Closes: pop-os#1794 Signed-off-by: Siddh Raman Pant <25429745+siddhpant@users.noreply.github.com>
wl-clipboard invisible window (literally just a dot shows up) can cause the tiler to make it take an entire window worth of space, and it is supposed to be immediately closed so we see a tiling flicker. And also sometimes the window dangles (there is an open bug for it), so it takes up unnecessary space. This window is not supposed to be tiled, in fact it has skip-taskbar flag set. Let's add exceptions for it. Closes: pop-os#1819 Signed-off-by: Siddh Raman Pant <25429745+siddhpant@users.noreply.github.com>
Nautilus file previews, like pressing space on a PDF file, is a temporary window and it can't zoom in, it is supposed to be overlaid. Let's add exception for it. Signed-off-by: Siddh Raman Pant <25429745+siddhpant@users.noreply.github.com>
Entering window-management mode removed the normal bindings and re-added the management bindings, then did the inverse on exit. This leads to journalctl spam since we overwrite a keybinding, and mutter logs overwrite warnings. Register the window-management mode bindings once with it being inactive initially (Shell.ActionMode.NONE), and later enable it (Shell.ActionMode.NORMAL) when entering the management mode, and then disabling on exit. Closes: pop-os#1820 Signed-off-by: Siddh Raman Pant <25429745+siddhpant@users.noreply.github.com>
This branch supports GNOME 46+ only according to README. Signed-off-by: Siddh Raman Pant <25429745+siddhpant@users.noreply.github.com>
Contributor
Author
|
@jacobgkau for master-noble. the other branch is now rebased over it. |
Member
|
Reference: #1821 |
jacobgkau
requested changes
Aug 20, 2026
jacobgkau
left a comment
jacobgkau
left a comment
Member
There was a problem hiding this comment.
Attempting to test this on GNOME 46 (on Pop!_OS 24.04 with GNOME Shell installed), I'm running into an issue where the window management shortcut keys (e.g. s, o, etc.) get stuck performing window management actions even when window management mode isn't active. This prevents me from typing those letters into any app windows (although they still work in the Activities overview). This doesn't seem to happen on the current master_noble. Perhaps it's a problem with f9576b8?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.