Skip to content

fix(spotify): validate redirect URL before auth - #22

Merged
postigodev merged 1 commit into
postigodev:mainfrom
xuyua9:codex/spotify-redirect-validation
Aug 26, 2026
Merged

fix(spotify): validate redirect URL before auth#22
postigodev merged 1 commit into
postigodev:mainfrom
xuyua9:codex/spotify-redirect-validation

Conversation

@xuyua9

@xuyua9 xuyua9 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • validate Spotify redirect URLs as explicit HTTP loopback IPs with ports before status and auth paths
  • distinguish invalid redirect configuration from missing credentials
  • add regression coverage for IPv4/IPv6 loopback and invalid callback URLs

The existing core path treated any non-empty redirect URL as configured, while local callback setup validated much later. This keeps the existing OAuth and playback behavior unchanged and makes the failure actionable earlier.

Relates to #10.

Validation

  • cargo fmt --all -- --check
  • cargo test -p desk_remote_core spotify:: --lib
  • cargo test -p desk_remote_core --lib
  • git diff --check

@vercel

vercel Bot commented Aug 13, 2026

Copy link
Copy Markdown

@xuyua9 is attempting to deploy a commit to the postigodev's projects Team on Vercel.

A member of the Team first needs to authorize it.

@postigodev
postigodev merged commit a9a8539 into postigodev:main Aug 26, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants