Fix native generation overwriting empty shared model files - #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are no shared schemas, native generation writes a nearly empty
common.models.ts, overwriting checked-in enums that JavaScript generation leaves intact. Omit the native shared model file for an empty schema collection to match JavaScript behavior.Adds 16 lifecycle regression cases covering JavaScript/native, JSON/YAML, incremental on/off, and models-only output. They assert no shared file is created on fresh output, existing enums and modification times survive regeneration with
clearOutput: false, and explicit cleanup removes the stale file. Native cases require full native rendering.Adds a schema-free
/healthendpoint to Petstore and derives a health-only Petstore fixture for every existing parity configuration. Both the unit parity suite and CI's Linux/macOS file-list and SHA-256 comparison consume this fixture. Explicit assertions verify that the endpoint is generated, the common model file is omitted, and the canonical native case uses full native rendering. The full Petstore fixture remains covered, including updated endpoint and metadata expectations.Validation on macOS:
Remote CI must validate Linux/macOS jobs for the latest commit.