fix!: isolate Axios from native and shared runtime imports - #97
Closed
urbankrepel-povio wants to merge 1 commit into
Closed
urbankrepel-povio wants to merge 1 commit into
urbankrepel-povio wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native consumers still needed Axios despite its optional peer metadata: the root entry point eagerly re-exported the Axios client, and shared REST utility declarations imported Axios types. Importing the built root with Axios unavailable reproduced the runtime failure.
Confine Axios-specific exports to
/axiosand remove Axios types from shared utilities. Message matching accepts unknown errors; filename extraction supports native Headers and Axios-style records. Add an isolated published-artifact consumer check to CI that imports non-Axios entry points and compiles declarations with skipLibCheck disabled without Axios, then verifies the Axios entry point with Axios installed.Breaking change: move root imports of RestClient, RestInterceptor, RequestInfo, RequestConfig, Response, and IRestClient to
@povio/openapi-codegen-cli/axios. NativeRestClient and shared helpers remain available from the root. The README documents this migration.Local validation:
/axiosfailed as expected when blocked and passed when installed.CI results are separate from these local checks.