fix: decouple shared REST utilities from Axios and verify tree-shaking - #98
Closed
urbankrepel-povio wants to merge 3 commits into
Closed
fix: decouple shared REST utilities from Axios and verify tree-shaking#98urbankrepel-povio wants to merge 3 commits into
urbankrepel-povio wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared REST utility declarations imported Axios types even for native consumers. Remove those imports, accept unknown errors in message matching, and support native Headers as well as Axios-style header records.
Preserve every existing root export, including RestClient, RestInterceptor, and their types. Consumers can continue using those imports; no migration is required. Native consumers can tree-shake unused Axios exports in a bundle or use the dedicated subpaths for direct runtime imports.
Add an isolated consumer check to CI covering:
Boundary: unbundled root imports still load Axios, and root declarations retain the Axios-specific types for compatibility. Rolldown warns about the absent peer before treating it as external and eliminating the unused import; this check does not establish missing-peer resolution behavior for every bundler.
Local validation: build, typecheck, lint, optional-peer consumer checks, tree-shaking checks, and both full test modes. CI results are separate from local checks.