Avoid passing partial arguments as string to sync_local - #219
Open
simolus3 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
sync_localis called for partial checkpoints, we currently pass a JSON array of bucket names around in Rust. This PR simplifies that by passing the actual bucket names around as a vector of string references, and only serializes to JSON in the single place where we bind them to a SQL query.I have also experimented with an approach splitting the statements (first finding updated rows, then looking up the latest oplog entry in a separate prepared statement) which avoids the serialization entirely, but causes many more reads in the sync local performance test.
AI use: Reviewed with Claude Code.